test: Deflake demo tests #5467
Merged
test: Deflake demo tests #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The demo tests occasionally timeout, in spite of being synchronous test cases. This is because of an async teardown process between tests, which can sometimes hang. This may indicate some condition in which player.destroy() could hang, though I have been unable to replicate that hypothetical condition in an explicit unit test. The hang goes away if we don't attach to the video element. Since the tests don't use the video element directly or attempt to load any content, we can just skip the video element attachment. Another thing that appears to resolve the hang is to await attach(), so a comment has been left to warn anyone modifying the code in the future not to use the constructor argument to attach a video element.
|
Incremental code coverage: No instrumented code was changed. |
theodab
approved these changes
Aug 8, 2023
joeyparrish
added a commit
that referenced
this pull request
Aug 19, 2023
The demo tests occasionally timeout, in spite of being synchronous test cases. This is because of an async teardown process between tests, which can sometimes hang. This may indicate some condition in which player.destroy() could hang, though I have been unable to replicate that hypothetical condition in an explicit unit test. The hang goes away if we don't attach to the video element. Since the tests don't use the video element directly or attempt to load any content, we can just skip the video element attachment. Another thing that appears to resolve the hang is to await attach(), so a comment has been left to warn anyone modifying the code in the future not to use the constructor argument to attach a video element.
joeyparrish
added a commit
that referenced
this pull request
Aug 20, 2023
The demo tests occasionally timeout, in spite of being synchronous test cases. This is because of an async teardown process between tests, which can sometimes hang. This may indicate some condition in which player.destroy() could hang, though I have been unable to replicate that hypothetical condition in an explicit unit test. The hang goes away if we don't attach to the video element. Since the tests don't use the video element directly or attempt to load any content, we can just skip the video element attachment. Another thing that appears to resolve the hang is to await attach(), so a comment has been left to warn anyone modifying the code in the future not to use the constructor argument to attach a video element.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo tests occasionally timeout, in spite of being synchronous test cases. This is because of an async teardown process between tests, which can sometimes hang.
This may indicate some condition in which player.destroy() could hang, though I have been unable to replicate that hypothetical condition in an explicit unit test.
The hang goes away if we don't attach to the video element. Since the tests don't use the video element directly or attempt to load any content, we can just skip the video element attachment.
Another thing that appears to resolve the hang is to await attach(), so a comment has been left to warn anyone modifying the code in the future not to use the constructor argument to attach a video element.