fix: Support fLaC and Opus codec strings in HLS #5454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves readability, I found the code very 'noisy'.
Chromium based browsers currently report fLaC and Opus as supported, but fail when playback is initiated. This commit provides a workaround. Older versions report them as not supported, even though the lower case variants work. Also, a necessary call to getCorrectAudioCodecs_ was missing. Fixes: #5453
These are the correct codec strings according to RFC 6381 section 3.3. Fixes: #5453
lonebyte
changed the title
|
Incremental code coverage: 98.25% |
This doesn't really matter, but I fixed it for completeness' sake.
avelad
added
type: bug
avelad
approved these changes
Aug 15, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Aug 19, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Aug 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the correct codec strings according to the specification:
The first commit just cleans up some code a bit.
The second commit provides a workaround for https://bugs.chromium.org/p/chromium/issues/detail?id=1422728
The third commit adds support for fLaC and Opus codec strings in HLS.
Fixes: #5453