Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve performance of setStreamProperties on low-end devices #5380

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 29, 2023

By reducing the number of promises in the Promises.all array we gain performance on low-end devices.

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Jun 29, 2023
@avelad avelad added this to the v4.4 milestone Jun 29, 2023
@avelad avelad changed the title feat: Reduce the number os promises when using setStreamProperties in MediaSourceEngine feat: Reduce the number of promises when using setStreamProperties in MediaSourceEngine Jun 29, 2023
@avelad avelad requested review from joeyparrish and theodab June 29, 2023 15:18
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@joeyparrish joeyparrish changed the title feat: Reduce the number of promises when using setStreamProperties in MediaSourceEngine feat: Improve performance of setStreamProperties on low-end devices Jun 29, 2023
@avelad avelad merged commit ddbc249 into shaka-project:main Jun 29, 2023
@avelad avelad deleted the improve-mse-engine-part2 branch June 30, 2023 12:21
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants