fix(UI): Fix resolution selection on src= #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
theodab
requested changes
Jun 28, 2023
This reverts commit f5f164c.
theodab
previously approved these changes
Jun 28, 2023
theodab
approved these changes
Jun 28, 2023
|
@theodab I'll wait to merge it to pass all tests. Thanks! |
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
With this change, when we are in src= mode we only leave the automatic mode in the resolution selector, since we will not be able to change the resolution. Fixes #5330
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
With this change, when we are in src= mode we only leave the automatic mode in the resolution selector, since we will not be able to change the resolution. Fixes #5330
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, when we are in src= mode we only leave the automatic mode in the resolution selector, since we will not be able to change the resolution.
Fixes #5330