fix(docs): fix player configuration code in drm config tutorial #5359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@vanyaxk Please, sign the CLA! Thanks! |
|
done, cheers |
|
Incremental code coverage: No instrumented code was changed. |
theodab
approved these changes
Jun 26, 2023
joeyparrish
approved these changes
Jun 26, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
This PR updates the DRM configuration tutorial. The configuration code example is incorrect, and also it suggests you can change the mapping, which is not true, you are only able to overwrite parts of it. Co-authored-by: Ivan Kohut <[email protected]>
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
This PR updates the DRM configuration tutorial. The configuration code example is incorrect, and also it suggests you can change the mapping, which is not true, you are only able to overwrite parts of it. Co-authored-by: Ivan Kohut <[email protected]>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the DRM configuration tutorial.
The configuration code example is incorrect, and also it suggests you can change the mapping, which is not true, you are only able to overwrite parts of it.