feat(HLS): Add support to HOLD-BACK in EXT-X-SERVER-CONTROL #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
|
Incremental code coverage: 100.00% |
theodab
approved these changes
Jun 12, 2023
| @@ -2680,6 +2687,8 @@ shaka.hls.HlsParser = class { | |||
| presentationDelay = this.config_.defaultPresentationDelay; | |||
| } else if (this.lowLatencyPresentationDelay_) { | |||
| presentationDelay = this.lowLatencyPresentationDelay_; | |||
| } else if (this.presentationDelay_) { | |||
There was a problem hiding this comment.
I was going to say "what if the tag has a HOLD-BACK value of 0" but I looked up the RFC and HOLD-BACK has an explicit minimum value, so that would be an invalid manifest anyway.
There was a problem hiding this comment.
From the spec
The value is a decimal-floating-point number of seconds that
indicates the server-recommended minimum distance from the end of
the Playlist at which clients should begin to play or to which
they should seek, unless PART-HOLD-BACK applies. Its value MUST
be at least three times the Target Duration.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.