-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HLS): Improve HLS parsing time #5264
Conversation
Incremental code coverage: 100.00% |
@theodab I added some asserts, can you approve the PR again? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and another thing just occurred to me too.
This would have probably been better in the last PR, organizationally, but...
Could you add a comment in the JSDoc for shaka.util.ManifestParserUtils.resolveUris
that explains that method is slow on SmartTV systems and should be delayed to after loading the manifest if possible? Or whatever the most accurate explanation for this is.
It'd be good to have documentation in the actual codebase, rather than just in GitHub comments.
I added the comment |
Related to #5261
This PR delays the creation of the final urls of the segments so that they are not calculated in each media playlist parsing.