feat: Add MP3 transmuxer #5208
Merged
feat: Add MP3 transmuxer #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
|
Incremental code coverage: 48.25% |
joeyparrish
previously requested changes
May 3, 2023
| Math.floor((sampleCoefficient * bitRate) / sampleRate + paddingBit) * | ||
| bytesInSlot; | ||
|
|
||
| const userAgent = navigator.userAgent || ''; |
There was a problem hiding this comment.
We have utilities for detecting browsers and versions in shaka.util.Platform
There was a problem hiding this comment.
Yes, but the utility is only for chrome browser, this is for all browser with Chrome string.
|
@theodab can you review it? Thanks! |
theodab
requested changes
May 11, 2023
theodab
approved these changes
May 12, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transmuxer is used in Firefox due the lack of support for
audio/mpeg