Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Convert CEA parsers to plugins #5195

Merged
merged 2 commits into from
Apr 29, 2023
Merged

feat: Convert CEA parsers to plugins #5195

merged 2 commits into from
Apr 29, 2023

Conversation

tykus160
Copy link
Member

Fixes #5178

Changes included:

  • converted CEA parsers to externs
  • added API to register/unregister CEA parsers
  • TextEngine now checks is CEA decoder registered
  • excluded CEA plugin from core build
  • added lcevc plugin to core build

Bundle size results (all in KB, compared to bf4b4a5):

  core complete - ui complete - ui - cea
before 246 473 473
after 231 474 459

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023 •
edited
Loading

Incremental code coverage: 95.37%

avelad
avelad requested changes Apr 27, 2023
View reviewed changes
lib/media/closed_caption_parser.js Outdated Show resolved Hide resolved
lib/media/closed_caption_parser.js Outdated Show resolved Hide resolved
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Apr 27, 2023
@avelad avelad added this to the v4.4 milestone Apr 27, 2023
@avelad avelad requested review from joeyparrish and theodab April 27, 2023 11:27
@tykus160 tykus160 requested a review from avelad April 27, 2023 13:00
@joeyparrish joeyparrish merged commit 7bda65d into shaka-project:main Apr 29, 2023
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
Merged
@tykus160 tykus160 deleted the wt-cea-plugin branch April 29, 2023 05:07
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Make CEA parser & decoder as plugins
3 participants
@tykus160 @avelad @joeyparrish