Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix handling of CC when switching between codecs #5160

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix: Fix handling of CC when switching between codecs #5160

merged 1 commit into from
Apr 19, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 19, 2023

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Apr 19, 2023
@avelad avelad added this to the v4.4 milestone Apr 19, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad mentioned this pull request Apr 19, 2023
Closed
@joeyparrish joeyparrish merged commit 6937325 into shaka-project:main Apr 19, 2023
@github-actions github-actions bot mentioned this pull request Apr 19, 2023
Merged
@avelad avelad deleted the text-codec-switch branch April 20, 2023 05:38
joeyparrish pushed a commit that referenced this pull request Apr 26, 2023
@avelad @joeyparrish
fix: Fix handling of CC when switching between codecs (#5160)
7ea71b4
joeyparrish pushed a commit that referenced this pull request Apr 26, 2023
@avelad @joeyparrish
fix: Fix handling of CC when switching between codecs (#5160)
d03c75f
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Apr 26, 2023
@avelad @joeyparrish
fix: Fix handling of CC when switching between codecs (#5160)
88a7710
joeyparrish pushed a commit that referenced this pull request Apr 26, 2023
@avelad @joeyparrish
fix: Fix handling of CC when switching between codecs (#5160)
7fcfea1
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Apr 26, 2023
@avelad @joeyparrish
fix: Fix handling of CC when switching between codecs (#5160)
9c3353c
joeyparrish pushed a commit that referenced this pull request Apr 26, 2023
@avelad @joeyparrish
fix: Fix handling of CC when switching between codecs (#5160)
c5cbdf8
joeyparrish pushed a commit that referenced this pull request Apr 26, 2023
@avelad @joeyparrish
fix: Fix handling of CC when switching between codecs (#5160)
3ea3fb4
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Apr 26, 2023
@avelad @joeyparrish
fix: Fix handling of CC when switching between codecs (#5160)
2203087
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @joeyparrish