Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Report HLS playlist updates as media playlist in network filters #5120

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix(HLS): Report HLS playlist updates as media playlist in network filters #5120

merged 1 commit into from
Mar 29, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 24, 2023

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Mar 24, 2023
@avelad avelad added this to the v4.4 milestone Mar 24, 2023
theodab
theodab previously approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks for catching that.

@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad requested a review from theodab March 24, 2023 12:27
@avelad
Copy link
Member Author

avelad commented Mar 27, 2023

@theodab can you review again? Thanks!

@theodab theodab merged commit c2a59d0 into shaka-project:main Mar 29, 2023
@github-actions github-actions bot mentioned this pull request Mar 29, 2023
Merged
@avelad avelad deleted the hls-playlist branch April 3, 2023 08:47
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @theodab