Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): Adding support for DTS Express in HLS fMP4 (#5112) #5117

Merged
merged 1 commit into from
Mar 23, 2023
Merged

fix(HLS): Adding support for DTS Express in HLS fMP4 (#5112) #5117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,4 @@ Blue Billywig <*@bluebillywig.com>
João Nabais <[email protected]>
Koen Romers <[email protected]>
Zhenghang Chen <[email protected]>
Xperi <*@xperi.com>
1 change: 1 addition & 0 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,3 +137,4 @@ Janroel Koppen <[email protected]>
João Nabais <[email protected]>
Koen Romers <[email protected]>
Zhenghang Chen <[email protected]>
Ashley Manners <[email protected]>
3 changes: 3 additions & 0 deletions lib/media/media_source_engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,9 @@ shaka.media.MediaSourceEngine = class {
'audio/mp4; codecs="ec-3"',
'audio/mp4; codecs="opus"',
'audio/mp4; codecs="flac"',
'audio/mp4; codecs="dtsc"', // DTS Digital Surround
'audio/mp4; codecs="dtse"', // DTS Express
'audio/mp4; codecs="dtsx"', // DTS:X
// WebM types
'video/webm; codecs="vp8"',
'video/webm; codecs="vp9"',
Expand Down
3 changes: 1 addition & 2 deletions lib/util/manifest_parser_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,7 @@ shaka.util.ManifestParserUtils.AUDIO_CODEC_REGEXPS_ = [
/^mp4a/,
/^[ae]c-3$/,
/^ac-4$/,
/^dts[cx]$/, // DTS Surround Sound
/^[du]dts$/, // DTS Surround Sound
/^dts[cex]$/, // DTS Digital Surround (dtsc), DTS Express (dtse), DTS:X (dtsx)
];


Expand Down