fix(HLS): don't do sequence mode workaround unless there's a text stream #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swac
changed the title
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
|
+1 for this. Last time #4553 only fixed for fMP4 on desktop browsers but on Android it is still affected in my follow-up testing. |
avelad
approved these changes
Mar 14, 2023
theodab
approved these changes
Mar 16, 2023
avelad
added a commit
to avelad/shaka-player
that referenced
this pull request
Mar 22, 2023
…text stream (shaka-project#5079)" This reverts commit fb22669.
avelad
added a commit
that referenced
this pull request
Jun 16, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VTT cue timing fix in #4217 seems to have caused a regression for videos without VTT streams, where the first segment would sometimes not play smoothly. It also appears to fix the gap jumping seen in the "Art of Motion (HLS, TS)" demo. This was partially fixed for fMP4 in #4553 but didn't fix the issue for MPEG-2 TS.
Fixes #4975.