feat(ads): Dispatch a player event for client-side ad errors #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
avelad
changed the title
avelad
previously approved these changes
Feb 28, 2023
|
Incremental code coverage: 33.33% |
theodab
previously requested changes
Feb 28, 2023
avelad
previously approved these changes
Mar 1, 2023
gingman
commented
Mar 1, 2023
Co-authored-by: Simon Gingras <[email protected]>
joeyparrish
approved these changes
Mar 1, 2023
avelad
approved these changes
Mar 2, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4335
The errors are now forwarded to the player