fix: Allow the playback of TS without mux.js #5041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
requested review from
joeyparrish,
JulianDomingo,
littlespex and
theodab
|
Incremental code coverage: 100.00% |
theodab
requested changes
Feb 28, 2023
theodab
reviewed
Feb 28, 2023
theodab
approved these changes
Feb 28, 2023
|
Could you please add something to the description explaining why this is needed? It seems like you had to add an assertion that transmuxer isn't used unless mux.js is provided, so it's not clear to me from the diff why you had to change anything. |
Done! |
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Mar 2, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because this transmuxer is always registered, and it doesn't check correctly whether mux.js is a dependency or not.