Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Fix CS volume ad #5016

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix(Ads): Fix CS volume ad #5016

merged 1 commit into from
Feb 21, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 21, 2023

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Feb 21, 2023
@avelad avelad added this to the v4.4 milestone Feb 21, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad merged commit 492b5f3 into shaka-project:main Feb 21, 2023
@avelad avelad deleted the ad-volume branch February 21, 2023 16:23
joeyparrish pushed a commit that referenced this pull request Mar 1, 2023
joeyparrish pushed a commit that referenced this pull request Mar 1, 2023
joeyparrish pushed a commit that referenced this pull request Mar 1, 2023
joeyparrish pushed a commit that referenced this pull request Mar 2, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants