feat(net): Added advanced type to filters #5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional parameter to request and response filters, of a new enum called AdvancedRequestType. This enum describes request types that are subtypes of the basic types. For example, INIT_SEGMENT is a type of SEGMENT. This gives users more information about the type of the request, while maintaining backwards compatibility. Closes shaka-project#4966
|
Incremental code coverage: 100.00% |
|
@theodab the tests are failing, can you review? Thanks! |
joeyparrish
reviewed
Feb 15, 2023
lib/net/networking_engine.js
Outdated
| */ | ||
| shaka.net.NetworkingEngine.AdvancedRequestType = { | ||
| 'INIT_SEGMENT': 0, | ||
| 'MEDIA_PLAYLIST': 1, |
There was a problem hiding this comment.
If we have MEDIA_PLAYLIST, we should have MASTER_PLAYLIST and MPD.
There was a problem hiding this comment.
Hm, now that it occurs to me, when playing an HLS media playlist directly, we don't know until the playlist is already downloaded...
Well, it's probably fine to say that the request is a master playlist request if we don't know.
avelad
approved these changes
Feb 16, 2023
joeyparrish
approved these changes
Feb 23, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional parameter to request and response filters, of a new enum called AdvancedRequestType.
This enum describes request types that are subtypes of the basic types. For example, INIT_SEGMENT is a type of SEGMENT.
This gives users more information about the type of the request, while maintaining backwards compatibility.
Closes #4966