docs: add error handling tutorial #4983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: docs
|
Incremental code coverage: No instrumented code was changed. |
martinstark
force-pushed
the
error-tutorial
branch
from
4c4bad6 to
3507fe1
Compare
martinstark
force-pushed
the
error-tutorial
branch
from
3507fe1 to
65332a9
Compare
martinstark
changed the title
joeyparrish
changed the title
joeyparrish
previously requested changes
Feb 9, 2023
theodab
requested changes
Feb 10, 2023
There was a problem hiding this comment.
I wonder if it would be worth putting this tutorial into the main flow of tutorials.
A more thorough explanation of error handling would be useful for new developers.
Of course, if this is made part of the main tutorials I would want to do a second, pickier round of code review.
martinstark
force-pushed
the
error-tutorial
branch
from
16998c5 to
6aae41c
Compare
|
@theodab thanks for the great feedback, I hope I've addressed it properly. Let me know how and where to link this if it's to be part of a different document as well. |
theodab
approved these changes
Feb 14, 2023
avelad
approved these changes
Feb 14, 2023
|
Thanks for the tutorial! |
|
Joey is busy with Chromecast-related stuff, and you've addressed his change request already, so I'm going to dismiss his review so I can merge this. |
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
Shaka error handling is getting increasingly more complex in order to "catch them all". This new tutorial describes both the basic method of error handling, as well as showing a few more advanced ways to handle specific errors. Closes #4484
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
Shaka error handling is getting increasingly more complex in order to "catch them all". This new tutorial describes both the basic method of error handling, as well as showing a few more advanced ways to handle specific errors. Closes #4484
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
Shaka error handling is getting increasingly more complex in order to "catch them all". This new tutorial describes both the basic method of error handling, as well as showing a few more advanced ways to handle specific errors. Closes #4484
joeyparrish
pushed a commit
that referenced
this pull request
Mar 2, 2023
Shaka error handling is getting increasingly more complex in order to "catch them all". This new tutorial describes both the basic method of error handling, as well as showing a few more advanced ways to handle specific errors. Closes #4484
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4484
Shaka error handling is getting increasingly more complex in order to "catch them all", I've tried to put together my current understanding of handling various cases in a tutorial. To read it with github md formatting: errors.md