Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HLS): Add support to HLS-AES128 low latency #4982

Merged
merged 1 commit into from
Feb 9, 2023
Merged

feat(HLS): Add support to HLS-AES128 low latency #4982

merged 1 commit into from
Feb 9, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 9, 2023

Closes #4981

@avelad avelad added this to the v4.4 milestone Feb 9, 2023
@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Feb 9, 2023
@avelad
Copy link
Member Author

avelad commented Feb 9, 2023

Note: This fix depends on #4952, that's why it is feat instead of fix

theodab
theodab approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that's all that was needed? I remember that when I was finishing the AES-128 code I was unsure how AES-128 and partial segments were supposed to work together.
Well, I'll take your word that it works on actual content.

@avelad
Copy link
Member Author

avelad commented Feb 9, 2023

@theodab It's just that a lot has changed since then... the main problem was that partial segments couldn't be read partially. But that has changed with the PR I mentioned.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Incremental code coverage: 100.00%

@avelad avelad merged commit 07787a8 into shaka-project:main Feb 9, 2023
@avelad avelad deleted the ll-aes-128 branch February 9, 2023 09:02
@github-actions github-actions bot mentioned this pull request Feb 9, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Low latency HLS-AES128 is not supported
2 participants
@avelad @theodab