Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tizen video error fixed by checking the extended MIME type #4973

Merged
merged 7 commits into from
Mar 6, 2023
Merged

fix: Tizen video error fixed by checking the extended MIME type #4973

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f3152d
fix: check if the extended mime type is supported
FernandoGarciaDiez Feb 3, 2023
982d72f
fix: Use codecs and mimeType converted values when checking the exten…
FernandoGarciaDiez Feb 3, 2023
d6392e1
Revert "fix: Use codecs and mimeType converted values when checking t…
FernandoGarciaDiez Feb 16, 2023
f1b52a7
Revert "fix: check if the extended mime type is supported"
FernandoGarciaDiez Feb 16, 2023
9b8e4dc
Merge branch 'main' into tizenVideoError
FernandoGarciaDiez Mar 1, 2023
49a6be3
fix: just for Tizen platform, check the if the extended mime type is …
FernandoGarciaDiez Mar 2, 2023
0dde62b
check potentially null parameters
FernandoGarciaDiez Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/polyfill/media_capabilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,19 @@ shaka.polyfill.MediaCapabilities = class {
if (shaka.util.Platform.isChromecast()) {
isSupported =
shaka.polyfill.MediaCapabilities.canCastDisplayType_(videoConfig);
} else if (shaka.util.Platform.isTizen()) {
let extendedType = videoConfig.contentType;
if (videoConfig.width && videoConfig.height) {
extendedType += `; width=${videoConfig.width}`;
extendedType += `; height=${videoConfig.height}`;
}
if (videoConfig.framerate) {
extendedType += `; framerate=${videoConfig.framerate}`;
}
if (videoConfig.bitrate) {
extendedType += `; bitrate=${videoConfig.bitrate}`;
}
isSupported = Capabilities.isTypeSupported(extendedType);
} else {
isSupported = Capabilities.isTypeSupported(videoConfig.contentType);
}
Expand Down