-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Document Picture-in-Picture #4969
Conversation
ded9042
to
0e4873c
Compare
0e4873c
to
69ad59c
Compare
@beaufortfrancois Please, fix the build errors. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing the functionality, several things I've seen:
- The dimensions that the player occupies in the window becomes 0, this can cause problems in some websites.
- The label of whether you are in PiP mode or not PiP is not updating correctly.
- Missing to detect if the functionality is allowed (see isPipAllowed_)
I agree and that's something I'd like to discuss. Adding a container may be enough. I'm not sure though.
Fixed. Thanks!
I forgot to upload that change earlier. Thank you! |
adf27d9
to
f3b1a3a
Compare
f3b1a3a
to
9ca67aa
Compare
31eced7
to
f302576
Compare
Incremental code coverage: 23.68% |
@joeyparrish , what is your opinion about that? |
90adeca
to
06fa86a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like the externs for documentPictureInPicture need to be updated to make that an implementation of EventTarget. I'll make the revision. |
Some other type information is missing, too, so I'm adding all of it. |
@joeyparrish Thanks for fixing externs! |
Do you folks know when this feature will be available in next shaka player release? |
@joeyparrish @avelad |
This PR adds experimental support for the Document Picture-in-Picture API in the Shaka Player.
I'm making some assumptions about how Shaka Player works and I'd love your review on this. Thank you!
Closes #4964