Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Failed to set 'currentTime' property on 'HTMLMediaElement' on a Hisense TV #4962

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix: Failed to set 'currentTime' property on 'HTMLMediaElement' on a Hisense TV #4962

merged 1 commit into from
Feb 3, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 3, 2023

Fixes #4888

@avelad avelad added type: bug Something isn't working correctly platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P2 Smaller impact or easy workaround labels Feb 3, 2023
@avelad avelad added this to the v4.4 milestone Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Incremental code coverage: 100.00%

@avelad avelad merged commit 5d93b8f into shaka-project:main Feb 3, 2023
@avelad avelad deleted the fix-video-wrapper-hisense branch February 3, 2023 10:27
@github-actions github-actions bot mentioned this pull request Feb 3, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Feb 9, 2023
@avelad @joeyparrish
fix: Failed to set 'currentTime' property on 'HTMLMediaElement' on a …
59d2e09 
…Hisense TV (#4962)

Fixes #4888
joeyparrish pushed a commit that referenced this pull request Feb 9, 2023
@avelad @joeyparrish
fix: Failed to set 'currentTime' property on 'HTMLMediaElement' on a …
bda4e50 
…Hisense TV (#4962)

Fixes #4888
joeyparrish pushed a commit that referenced this pull request Feb 9, 2023
@avelad @joeyparrish
fix: Failed to set 'currentTime' property on 'HTMLMediaElement' on a …
b753933 
…Hisense TV (#4962)

Fixes #4888
joeyparrish pushed a commit that referenced this pull request Feb 9, 2023
@avelad @joeyparrish
fix: Failed to set 'currentTime' property on 'HTMLMediaElement' on a …
0559cf2 
…Hisense TV (#4962)

Fixes #4888
This was referenced Feb 9, 2023
Merged
Merged
Merged
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Failed to set 'currentTIme' property on 'HTMLMediaElement' on an older Hisense TV
2 participants
@avelad @littlespex