fix(WebVTT): Fix voices with styles and support to multiple styles #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 68.63% |
joeyparrish
requested changes
Jan 23, 2023
lib/text/vtt_text_parser.js
Outdated
| propertyLines = payload[1].split(';'); | ||
| for (const styleBlock of styleBlocks) { | ||
| let styleSelector = 'global'; | ||
| // Look for what is within parentisesis. For example: |
lib/text/vtt_text_parser.js
Outdated
| cue.fontSize = value; | ||
| break; | ||
| case 'font-weight': | ||
| if (parseInt(value, 10) >= 700) { |
There was a problem hiding this comment.
What about non-integer values?
| cue.fontStyle = shaka.text.Cue.fontStyle.ITALIC; | ||
| break; | ||
| case 'oblique': | ||
| cue.backgroundColor = value; |
There was a problem hiding this comment.
This test case uses "background" instead of "background-color". Could you support that, too, even just making 'background' an alias to 'background-color' for now?
WEBVTT
STYLE
*|*::cue(b) {
background: blue
}
|*::cue(i) {
color: blue;
}
::cue(i) {
background: white;
}
*::cue(b) {
color: white;
}
::cue {
font-size: 11px;
}
00:00:00.000 --> 00:00:05.000
This <i>is</i> a <b>test</b> subtitle
joeyparrish
approved these changes
Jan 24, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Jan 30, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Jan 30, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.