Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upload screenshots on test failures #4917

Merged

Conversation

joeyparrish
Copy link
Member

This will upload screenshots when the Selenium lab tests fail. This can be used to get screenshot changes either for examination or for updating the test expectations.

avelad
avelad previously approved these changes Jan 19, 2023
This will upload screenshots when the Selenium lab tests fail.  This can be used to get screenshot changes either for examination or for updating the test expectations.
@joeyparrish
Copy link
Member Author

NOTE: Due to the complexity of testing Actions workflows, this change has not yet been tested. But a similar step appears in build-and-test and works.

@joeyparrish joeyparrish merged commit eeb647c into shaka-project:main Jan 19, 2023
@joeyparrish joeyparrish deleted the selenium-upload-screenshots branch January 19, 2023 21:49
@github-actions
Copy link
Contributor

Incremental code coverage: No instrumented code was changed.

joeyparrish added a commit that referenced this pull request Jan 30, 2023
This will upload screenshots when the Selenium lab tests fail. This can
be used to get screenshot changes either for examination or for updating
the test expectations.
joeyparrish added a commit that referenced this pull request Jan 30, 2023
This will upload screenshots when the Selenium lab tests fail. This can
be used to get screenshot changes either for examination or for updating
the test expectations.
joeyparrish added a commit that referenced this pull request Jan 30, 2023
This will upload screenshots when the Selenium lab tests fail. This can
be used to get screenshot changes either for examination or for updating
the test expectations.
joeyparrish added a commit that referenced this pull request Jan 30, 2023
This will upload screenshots when the Selenium lab tests fail. This can
be used to get screenshot changes either for examination or for updating
the test expectations.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants