fix: Sync each segment against EXT-X-PROGRAM-DATE-TIME #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 85.00% |
avelad
added
type: bug
|
@joeyparrish , is something missing? is it ready to review? |
|
I have yet to verify the change with real content, and the test stream from the associated issue was unrealistic to the point of making this change have no effect. I got new content from multiple partners last night, so I'll be testing that today. When I've verified the change, I'll take it out of draft status. But feedback is welcome any time. |
joeyparrish
force-pushed
the
hls-av-sync
branch
from
bd4a421 to
81c3dfd
Compare
|
Rebased on top of #4881, still waiting for new content to verify |
|
I got new content from another partner through internal channels. Unfortunately, it appears that this still has a bug in it somewhere that is placing segments at the wrong times. I haven't found the cause yet. |
joeyparrish
force-pushed
the
hls-av-sync
branch
from
81c3dfd to
29cdf35
Compare
joeyparrish
requested review from
avelad,
theodab,
JulianDomingo and
littlespex
avelad
approved these changes
Jan 12, 2023
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
Closes #4589 Backported to v4.2.x: - patched in lowestSyncTime_ from v4.3.x in HlsParser
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
Closes #4589 Backported to v4.2.x: - patched in lowestSyncTime_ from v4.3.x in HlsParser
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4589