Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix parsing error on Chromecast when resyncing HLS #4869

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix: Fix parsing error on Chromecast when resyncing HLS #4869

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4806c8
fix: Fix parsing error on Chromecast when resyncing HLS
joeyparrish Jan 4, 2023
2ab9024
fix typo
joeyparrish Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/media/media_source_engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,18 @@ shaka.media.MediaSourceEngine = class {
*/
async resync(contentType, timestampOffset) {
goog.asserts.assert(this.sequenceMode_,
'resyncAudio only used with sequence mode!');
'resync only used with sequence mode!');
// Queue an abort() to help MSE splice together overlapping segments.
// We set appendWindowEnd when we change periods in DASH content, and the
// period transition may result in overlap.
//
// An abort() also helps with MPEG2-TS. When we append a TS segment, we
// always enter a PARSING_MEDIA_SEGMENT state and we can't change the
// timestamp offset. By calling abort(), we reset the state so we can
// set it.
this.enqueueOperation_(
contentType,
() => this.abort_(contentType));
await this.enqueueOperation_(
contentType,
() => this.setTimestampOffset_(contentType, timestampOffset));
Expand Down