Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Avoid submitting form if player is inside form #4866

Merged
merged 3 commits into from
Jan 3, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "fix(ui): adding button type on button element"
This reverts commit 0befef0.
WINOFFRG committed Jan 3, 2023
commit a4f70c491e1f5ca2a0c0d28cba9371fa81eaa403
5 changes: 2 additions & 3 deletions lib/util/dom_utils.js
Original file line number Diff line number Diff line change
@@ -36,9 +36,7 @@ shaka.util.Dom = class {
* @return {!HTMLButtonElement}
*/
static createButton() {
const button = document.createElement('button');
button.setAttribute('type', 'button');
return /** @type {!HTMLButtonElement} */(button);
return /** @type {!HTMLButtonElement} */(document.createElement('button'));
}


@@ -91,3 +89,4 @@ shaka.util.Dom = class {
}
}
};