fix: Fix rare exception after StreamingEngine teardown #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the timing of certain events can cause a seek callback to fire on StreamingEngine after it has been destroyed. This checks for that condition to avoid an exception. Closes shaka-project#4813
avelad
approved these changes
Dec 13, 2022
avelad
added
type: bug
|
Incremental code coverage: 75.00% |
littlespex
approved these changes
Dec 13, 2022
|
375 test runs in a row passed. I had planned 400, but I'm running out of time to finish cherry-picking and preparing releases, so I'm going to go ahead and merge the fix now. |
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
In some cases, the timing of certain events can cause a seek callback to fire on StreamingEngine after it has been destroyed. This checks for that condition to avoid an exception. Closes #4813
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
In some cases, the timing of certain events can cause a seek callback to fire on StreamingEngine after it has been destroyed. This checks for that condition to avoid an exception. Closes #4813
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
In some cases, the timing of certain events can cause a seek callback to fire on StreamingEngine after it has been destroyed. This checks for that condition to avoid an exception. Closes #4813
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
In some cases, the timing of certain events can cause a seek callback to fire on StreamingEngine after it has been destroyed. This checks for that condition to avoid an exception. Closes #4813
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
…#4830) In some cases, the timing of certain events can cause a seek callback to fire on StreamingEngine after it has been destroyed. This checks for that condition to avoid an exception. Closes shaka-project#4813
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the timing of certain events can cause a seek callback to fire on StreamingEngine after it has been destroyed. This checks for that condition to avoid an exception.
Closes #4813