fix(HLS): Fix AV sync over ad boundaries #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If server-side ad segments aren't aligned, AV could get out of sync by accumulating errors in the timestampOffset of the SourceBuffers. This fixes the issue by tracking discontinuity boundaries and resetting timestampOffset to theoretical segment start times when a boundary is crossed. Closes shaka-project#4589
|
Looks like I neglected to update some test cases. Also, this turns out to be only a partial solution, so I took out the "closes" verb in the PR description. |
|
Incremental code coverage: 97.44% |
avelad
added
type: bug
avelad
approved these changes
Dec 13, 2022
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
If server-side ad segments aren't aligned, AV could get out of sync by accumulating errors in the timestampOffset of the SourceBuffers. This improves the issue by tracking discontinuity boundaries and resetting timestampOffset to theoretical segment start times when a boundary is crossed. Issue #4589
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
If server-side ad segments aren't aligned, AV could get out of sync by accumulating errors in the timestampOffset of the SourceBuffers. This improves the issue by tracking discontinuity boundaries and resetting timestampOffset to theoretical segment start times when a boundary is crossed. Issue #4589
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Jan 13, 2023
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
If server-side ad segments aren't aligned, AV could get out of sync by accumulating errors in the timestampOffset of the SourceBuffers. This improves the issue by tracking discontinuity boundaries and resetting timestampOffset to theoretical segment start times when a boundary is crossed. Issue shaka-project#4589
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If server-side ad segments aren't aligned, AV could get out of sync by accumulating errors in the timestampOffset of the SourceBuffers.
This improves the issue by tracking discontinuity boundaries and resetting timestampOffset to theoretical segment start times when a boundary is crossed.
Issue #4589