Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Suppress error log from fullscreen button on desktop #4823

Merged

Conversation

joeyparrish
Copy link
Member

Closes #4822

@github-actions
Copy link
Contributor

Incremental code coverage: 0.00%

@joeyparrish joeyparrish merged commit 99da4ce into shaka-project:main Dec 13, 2022
@joeyparrish joeyparrish deleted the fix-fullscreen-error-log branch December 13, 2022 02:04
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Feb 8, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screen.orientation.lock() error dispatched in desktop UI
2 participants