Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HLS): Improve detection of basic info from Media Playlist #4809

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 9, 2022

No description provided.

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Dec 9, 2022
@avelad avelad added this to the v4.4 milestone Dec 9, 2022
@avelad avelad requested review from joeyparrish and theodab December 9, 2022 15:18
@avelad
Copy link
Member Author

avelad commented Dec 9, 2022

@joeyparrish , I'll let you decide if you consider it fix or feat

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Incremental code coverage: 72.87%

@avelad avelad force-pushed the media-playlist-basic-info branch from bc7d7bc to 929faf0 Compare December 9, 2022 17:07
@avelad avelad force-pushed the media-playlist-basic-info branch from 929faf0 to cc18033 Compare December 12, 2022 12:13
@avelad avelad force-pushed the media-playlist-basic-info branch from 38d0636 to e348a4b Compare December 13, 2022 16:10
@avelad
Copy link
Member Author

avelad commented Jan 24, 2023

@theodab can you review it? Thanks!

@avelad
Copy link
Member Author

avelad commented Jan 27, 2023

Thanks @theodab !

@theodab theodab merged commit d465942 into shaka-project:main Jan 27, 2023
@avelad avelad deleted the media-playlist-basic-info branch January 27, 2023 07:47
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants