fix: Manually order key for decodingInfo cache #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on @joeyparrish's comments on #4789. |
|
Incremental code coverage: 100.00% |
avelad
previously approved these changes
Dec 6, 2022
avelad
added
the
priority: P1
joeyparrish
reviewed
Dec 6, 2022
lib/util/stream_utils.js
Outdated
| @@ -510,10 +510,45 @@ shaka.util.StreamUtils = class { | |||
| * @private | |||
| */ | |||
| static async getDecodingInfosForVariant_(variant, decodingConfig) { | |||
| // Construct a key for that decoding config. By using this instead of plain | |||
There was a problem hiding this comment.
I don't love that this is brittle against future changes to MediaCapabilities, and the failure mode is worse now. We would have to add new fields here or else end up with potentially bogus results (where cache hits ignore certain fields).
We can defer this part, IMO. Iteration order is spec'd as the order the fields were created in, and that should hold well enough for now.
There was a problem hiding this comment.
Actually, I just thought of a better approach for this that should be less brittle. Let me give it a shot...
avelad
approved these changes
Dec 7, 2022
joeyparrish
approved these changes
Dec 7, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.