-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cast): Use cast platform APIs in MediaCapabilties polyfill #4727
Merged
joeyparrish
merged 16 commits into
shaka-project:main
from
JulianDomingo:4726-account-for-extended-mime-type-parameters-in-mediacapabilitiesdecodinginfo-polyfill-for-cast-platform
Dec 1, 2022
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
aa973af
Initial fix with temp debug logs.
JulianDomingo 0ee3554
Removed console debug logs after verifying eotf param on a 4K HDR Rok…
JulianDomingo 4873f27
Updated comment on smpte2048 check.
JulianDomingo 2d56c99
Merge branch 'main' into 4726-account-for-extended-mime-type-paramete…
JulianDomingo ef09c30
Added existence check for transferFunction parameter.
JulianDomingo 51a96ea
Handled review comments (iter #0) and added unit tests. Also correcte…
JulianDomingo 9588678
Fixed unit test linting errors.
JulianDomingo b60d59a
Restored cast namespace after polyfill test executions.
JulianDomingo bf81981
Use window.cast instead of cast for namespace checking.
JulianDomingo 279b029
Sanity check to confirm issue with CDT() support on Selenium lab test…
JulianDomingo 1dd0722
Updated canDisplayType() checks to guard against instable implementat…
JulianDomingo 6a8cf51
Fall back to MediaSource.isTypeSupported() if cast APIs aren't availa…
JulianDomingo d0701ea
Removed window.cast to trigger CAST_API_UNAVAILABLE error for lab chr…
JulianDomingo 720fe11
Verifying lab tests fail without check for cast.__platform__ and cast…
JulianDomingo 8465a99
Re-instated deleted code from previous commit, which prevented cast l…
JulianDomingo be1065a
Handling PR review comments.
JulianDomingo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very strange. I'd like to help you look into that, but I don't want to hold up the PR for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, was held up on this for a while - the lab tests were failing without this check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent a solid day on this, and it's time for me to give up for now. I managed to forward the Cast platform APIs through an iframe boundary, but not in a way that is compatible with Karma's websocket usage. :-(