fix: Fix compiler error on static use of "this" #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An internal build system failed to compile v4.3.0 due to the use of static "this". This change fixes it. Unfortunately, we are already running the latest public compiler release, so there is no way we could have caught this on GitHub.
JulianDomingo
previously approved these changes
Nov 11, 2022
theodab
approved these changes
Nov 12, 2022
|
Incremental code coverage: 100.00% |
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
An internal build system failed to compile v4.3.0 due to the use of static "this". This change fixes it. Unfortunately, we are already running the latest public compiler release, so there is no way we could have caught this on GitHub.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An internal build system failed to compile v4.3.0 due to the use of static "this". This change fixes it.
Unfortunately, we are already running the latest public compiler release, so there is no way we could have caught this on GitHub.