Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix timestamp offset for ID3 on DAI-HLS #4696

Merged
merged 3 commits into from
Nov 14, 2022
Merged

fix: Fix timestamp offset for ID3 on DAI-HLS #4696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c6d48d
fix: Fix timestamp offset for ID3 on DAI-HLS
avelad Nov 11, 2022
efc703a
Fix typo
avelad Nov 11, 2022
0491de2
Add comment
avelad Nov 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/media/media_source_engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,11 +586,14 @@ shaka.media.MediaSourceEngine = class {
mimeType = this.transmuxers_[contentType].getOrginalMimeType();
}
if (shaka.util.TsParser.probe(uint8ArrayData)) {
const metadata = new shaka.util.TsParser().parse(uint8ArrayData)
.getMetadata();
const tsParser = new shaka.util.TsParser().parse(uint8ArrayData);
// The SourceBuffer timestampOffset may or may not be set yet, so this is
// the timestamp offset that would eventually compute for this segment
// either way.
const timestampOffset =
reference.startTime - (tsParser.getStartTime()[contentType] || 0);
joeyparrish marked this conversation as resolved.
Show resolved Hide resolved
const metadata = tsParser.getMetadata();
if (metadata.length) {
const timestampOffset =
this.sourceBuffers_[contentType].timestampOffset;
this.onMetadata_(metadata, timestampOffset,
reference ? reference.endTime : null);
}
Expand Down