fix: Fix HLS lazy-loading exception during update #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have yet to determine if new tests cases make sense for this. I will follow up. |
If a stream switch occurs during a playlist update, that update may need to be cancelled. This handles this edge case to prevent an exception trying to access stream.segmentIndex. Closes shaka-project#4647
joeyparrish
force-pushed
the
fix-hls-lazy-loading-race-2
branch
from
1089915 to
1df4bff
Compare
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
avelad
previously approved these changes
Nov 3, 2022
theodab
previously approved these changes
Nov 3, 2022
|
New tests added. |
theodab
approved these changes
Nov 4, 2022
avelad
approved these changes
Nov 4, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a stream switch occurs during a playlist update, that update may need to be cancelled. This handles this edge case to prevent an exception trying to access stream.segmentIndex.
Closes #4647