fix: Fix drm.keySystemsMapping config #4425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the config by adding a missing override in the config parser. This also adds test coverage for the feature. Closes shaka-project#4422
|
Incremental code coverage: 100.00% |
theodab
approved these changes
Aug 18, 2022
JulianDomingo
approved these changes
Aug 18, 2022
| drmEngine.initForPlayback(variants, manifest.offlineSessionIds)) | ||
| .toBeRejected(); | ||
|
|
||
| expect(drmEngine.initialized()).toBe(false); |
There was a problem hiding this comment.
FMI, this scenario is set to fail DRM initialization because in L690, it was set to fail all key systems?
But even then, it still reaches these lines:
shaka-player/lib/media/drm_engine.js
Lines 351 to 361 in c935cc1
avelad
pushed a commit
that referenced
this pull request
Aug 31, 2022
This fixes the config by adding a missing override in the config parser. This also adds test coverage for the feature. Closes #4422
avelad
pushed a commit
that referenced
this pull request
Aug 31, 2022
This fixes the config by adding a missing override in the config parser. This also adds test coverage for the feature. Closes #4422
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the config by adding a missing override in the config parser. This also adds test coverage for the feature.
Closes #4422