Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve gap-detection robustness #4399

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

joeyparrish
Copy link
Member

This raises the default gap-detection threshold from 0.1 seconds for
some platforms and 0.5 seconds for others to 0.5 seconds universally.
This fixes test flake in gap-jumping tests on Android and may improve
gap-jumping generally for certain platforms or content.

This raises the default gap-detection threshold from 0.1 seconds for
some platforms and 0.5 seconds for others to 0.5 second universally.
This fixes test flake in gap-jumping tests on Android and may improve
gap-jumping generally for certain platforms or content.
@joeyparrish joeyparrish merged commit 4293a14 into shaka-project:main Aug 10, 2022
@joeyparrish joeyparrish deleted the gap-detection-default branch August 10, 2022 20:59
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants