feat: add Amazon Fire TV platform support #4375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isBrowserSupported
function in theutils/player.js
fails if the Safari Version is < 13. However, this check doesn't work for Amazon Fire TV devices. Even tho they have aVersion/4.0
in the user agent string, the browser still supports all other requirements to support playback with Shaka Player.Here are a couple of examples of the different FireTV device user agents:
Fire TV Stick 4K - 1st Gen:
Fire TV Stick - 3rd Gen:
The fix involves identifying the Amazon Fire TV device based on the parameters described in the Amazon Fire TV docs and disabling the Safari version check for these devices.
Type of change
not work as expected)
Checklist:
TextDisplayer
are failing even on the main branch for Edge and Firefox, even tho those tests seem irrelevant to the changes in this PR). I'll create an issue around that.