fix: exception if on early adError #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If onAdError is called before onAdStart_ then onAdComplete_ uses this.ad_ which is undefined. This can happen if a VAST XML file contains no ads.
jukart
changed the title
joeyparrish
approved these changes
Jul 19, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Aug 16, 2022
If onAdError is called before onAdStart_ then onAdComplete_ uses this.ad_ which is undefined. This can happen if a VAST XML file contains no ads. Fixes #4004
joeyparrish
pushed a commit
that referenced
this pull request
Aug 16, 2022
If onAdError is called before onAdStart_ then onAdComplete_ uses this.ad_ which is undefined. This can happen if a VAST XML file contains no ads. Fixes #4004
joeyparrish
pushed a commit
that referenced
this pull request
Aug 16, 2022
If onAdError is called before onAdStart_ then onAdComplete_ uses this.ad_ which is undefined. This can happen if a VAST XML file contains no ads. Fixes #4004
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If onAdError is called before onAdStart_ then onAdComplete_ uses
this.ad_ which is undefined.
This can happen if a VAST XML file contains no ads.
fixes #4004