-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hls): add keySystemsMapping to hls config #4253
Conversation
Add new config manifest.hls.keySystemsMapping to allow use another keySystems. Por example: com.microsoft.playready.recommendation
I am not convinced that this is the best solution for I think we might need some kind of built-in fallback in |
We have the same solution for DASH |
I had no idea! I did some digging and found PR #3276, which I even commented on in an approving manner before it was ultimately merged by someone else. No memory of this! 2021 was a rough year. I would prefer that you move this field to the ac5acc8#diff-7abf4aa2639707ce10a19703663841fae6c5638809faf4dfb2f1894791f154ddL2948 If you do something like that, we can move the field now, but don't have to break compatibility until we're ready for v5. |
Ok, I’ll do it tomorrow. One question, are you agree with my config? Or do you prefer another type of mapping? |
I do see the value of a default mapping and automatic probing equivalent key system names in an order. By the way, I started a discussion in Chromium for supporting PlayReady key system in Windows: https://bugs.chromium.org/p/chromium/issues/detail?id=1328921 |
@alvaro, yes, I think this is fine. I would have preferred it if we didn't require a configuration to use the best key system ID for PlayReady, because I think many people will overlook this. But it's also simple, and we're already doing it. Although @valotvince said before that his attempts to do an automatic failover were turning out to be too complex, I would still be interested in something like that in the future. It wouldn't have to be in conflict with the mapping necessarily, and perhaps both could coexist. |
Replaced with #4254 |
Add new config manifest.hls.keySystemsMapping to allow use another keySystems. Por example: com.microsoft.playready.recommendation
Closes #4243