Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hls): add keySystemsMapping to hls config #4253

Closed
wants to merge 1 commit into from

Conversation

avelad
Copy link
Member

@avelad avelad commented May 24, 2022

Add new config manifest.hls.keySystemsMapping to allow use another keySystems. Por example: com.microsoft.playready.recommendation

Closes #4243

Add new config manifest.hls.keySystemsMapping to allow use another keySystems. Por example: com.microsoft.playready.recommendation
@avelad avelad requested a review from theodab May 24, 2022 09:28
@avelad avelad added this to the v4.1 milestone May 24, 2022
@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format labels May 24, 2022
@avelad avelad requested a review from joeyparrish May 24, 2022 16:51
@joeyparrish
Copy link
Member

I am not convinced that this is the best solution for com.microsoft.playready.recommendation. I believe that for some devices, PlayReady must use the older key system ID. In MS Edge, you can use either, but should use the new one.

I think we might need some kind of built-in fallback in DrmEngine to automatically try and prefer .recommendation when possible.

@avelad
Copy link
Member Author

avelad commented May 24, 2022

We have the same solution for DASH

@avelad avelad closed this May 24, 2022
@avelad avelad reopened this May 24, 2022
@joeyparrish
Copy link
Member

We have the same solution for DASH

I had no idea! I did some digging and found PR #3276, which I even commented on in an approving manner before it was ultimately merged by someone else. No memory of this! 2021 was a rough year.

I would prefer that you move this field to the manifest level and combine with the DASH version. You can see an example of a backward compatibility shim here:

ac5acc8#diff-7abf4aa2639707ce10a19703663841fae6c5638809faf4dfb2f1894791f154ddL2948

If you do something like that, we can move the field now, but don't have to break compatibility until we're ready for v5.

@avelad
Copy link
Member Author

avelad commented May 24, 2022

Ok, I’ll do it tomorrow. One question, are you agree with my config? Or do you prefer another type of mapping?

@wjywbs
Copy link
Contributor

wjywbs commented May 24, 2022

I think we might need some kind of built-in fallback in DrmEngine to automatically try and prefer .recommendation when possible.

I do see the value of a default mapping and automatic probing equivalent key system names in an order. By the way, I started a discussion in Chromium for supporting PlayReady key system in Windows:

https://bugs.chromium.org/p/chromium/issues/detail?id=1328921

@joeyparrish
Copy link
Member

@alvaro, yes, I think this is fine. I would have preferred it if we didn't require a configuration to use the best key system ID for PlayReady, because I think many people will overlook this. But it's also simple, and we're already doing it.

Although @valotvince said before that his attempts to do an automatic failover were turning out to be too complex, I would still be interested in something like that in the future. It wouldn't have to be in conflict with the mapping necessarily, and perhaps both could coexist.

@avelad
Copy link
Member Author

avelad commented May 25, 2022

Replaced with #4254

@avelad avelad closed this May 25, 2022
@avelad avelad removed this from the v4.1 milestone May 25, 2022
@avelad avelad deleted the keysytemsmpagging-hls branch May 25, 2022 09:41
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.microsoft.playready to com.microsoft.playready.recommendation mapping in HLS
3 participants