fix(demo): Fix default demo index versions #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script for deploying the demo version index page has a function that chooses which versions to display. This script has a special mode meant for testing that shows a default list of demo versions. This mode was only supposed to trigger when run locally, but the check did not work properly, so the demo version index was deploying with a very out-of-date list of versions. This fixes that check. Closes shaka-project#4074
theodab
added
the
component: demo page
|
This approach was suggested by @joeyparrish in the discussion for the now-abandoned #4098. |
joeyparrish
approved these changes
Apr 11, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Apr 21, 2022
The script for deploying the demo version index page has a function that chooses which versions to display. This script has a special mode meant for testing that shows a default list of demo versions. This mode was only supposed to trigger when run locally, but the check did not work properly, so the demo version index was deploying with a very out-of-date list of versions. This fixes that check. Closes #4074 <!-- Please remember to: 1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and PR title (https://www.conventionalcommits.org/) 2. Tag any related or fixed issues ("Issue #123", "Closes #420") 3. Sign the Google CLA if you haven't (https://cla.developers.google.com) You may delete this comment from the PR description. -->
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script for deploying the demo version index page has a function
that chooses which versions to display. This script has a special
mode meant for testing that shows a default list of demo versions.
This mode was only supposed to trigger when run locally, but the
check did not work properly, so the demo version index was deploying
with a very out-of-date list of versions.
This fixes that check.
Closes #4074
BEGIN_COMMIT_OVERRIDE
ci: Fix default demo index versions
END_COMMIT_OVERRIDE