fix: Fix broken deps file generation on Windows #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes broken deps file generation on Window by upgrading to a pre-release version of the deps tool. The upstream issue was filed in google/closure-library#1159 and fixed in google/closure-library#1160. This issue has never affected a release version of Shaka Player, and was introduced when we switched deps tools in 6f274cb. Closes shaka-project#4085
theodab
approved these changes
Mar 31, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes broken deps file generation on Window by upgrading to a
pre-release version of the deps tool. The upstream issue was filed in
google/closure-library#1159 and fixed in
google/closure-library#1160.
This issue has never affected a release version of Shaka Player, and
was introduced when we switched deps tools in 6f274cb.
Closes #4085