Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for "On"/"Off"
Current Russian translation for "On" and "Off" are incorrect and misleading.
Current translation (
Включить
) forOff
meansTurn on
.Current translation (
Отключить
) forOn
meansTurn off
.Current translation works in context of "Picture in picture", but completly incorrect in context of captions.
Is context of captions it looks like this:
As you see, last item doing exactly opposite (turning subtitles off) of what Russian translation says.
New translations
Выкл.
forOff
andВкл.
forOn
works in all cases. By the way, same spellings are used on popular video services such as YouTube:Fix for "Captions"
Current translation (
Титры
) typically means credits at the start/end of the movie and it looks odd in that context. I changed translation toСубтитры
(subtitles, closed captions). I know "subtitles" and "captions" are a bit different in English, but in RussianСубтитры
are used for both cases. YouTube and other videos services also usesСубтитры
(you can see it on the previous screenshot)Fix for "Ad"
Current translation for
Ad
(Объявление
) typically used about ads or announcements in newspapers or other paper mediums. It's rarely used in context of Internet Ads and especially in context of video ads. You typically seeРеклама
(new translation, meansAd, Advertising
) in context of Internet Ads.Type of change
not work as expected)
Checklist:
./build/all.py
and the build passes./build/test.py
and all tests pass