feat(ui): Add quality selection for audio-only content #3649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The present pull request aims to provide a solution to #2071 (Quality selection UI for audio-only content) by replacing the resolution selection menu with a quality selection menu in audio-only content.
Fixes: #2071
How to preview
Initialize the client with a config that contains
quality
in thecontrolPanelElements
and load the player with an audio-only manifest.Changelog
test/ui/ui_integration.js
Removes the integration test that checks for a hidden resolution button in audio-only content.
test/ui/ui_unit.js
Expects the correct version of the resolution button and appropriate bandwidth parsing for an audio-only manifest.
ui/locales/en.json
Adds the
quality
locale as reference in English.ui/locales/source.json
Adds a description and meaning for the
quality
locale.ui/resolution_selection.js
Removes
TODO
fix that hid resolution button for audio-only content by adding the removal of duplicates, sorting and naming of available tracks flows for either video or audio-only content.