Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Incorrect icon Play after video ends and rewind #3515

Merged
merged 1 commit into from
Jul 10, 2021
Merged

Fix: Incorrect icon Play after video ends and rewind #3515

merged 1 commit into from
Jul 10, 2021

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 9, 2021

Close: #3495

theodab
theodab approved these changes Jul 10, 2021
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@shaka-bot
Copy link
Collaborator

All tests passed!

@theodab theodab merged commit 8b418bb into shaka-project:master Jul 10, 2021
@theodab
Copy link
Contributor

theodab commented Jul 10, 2021

Thank you for your contributions, as always!

@avelad avelad deleted the replay-button-rewind branch July 12, 2021 06:11
joeyparrish pushed a commit that referenced this pull request Jul 13, 2021
@joeyparrish
Fix(UI): Update Play icon after seeking from end (#3515)
1d3a1ad 
We change the "play" button icon to become "rewind" when the video ends.
However, previously we did not update the icon again when seeking.
This would lead to the icon still looking like a "rewind" button if
the user seeks back from the end of the video.
This fixes that, by making the button listen to "seeking" events.
joeyparrish pushed a commit that referenced this pull request Jul 13, 2021
@joeyparrish
Fix(UI): Update Play icon after seeking from end (#3515)
4d32479 
We change the "play" button icon to become "rewind" when the video ends.
However, previously we did not update the icon again when seeking.
This would lead to the icon still looking like a "rewind" button if
the user seeks back from the end of the video.
This fixes that, by making the button listen to "seeking" events.
@renovate renovate bot mentioned this pull request Jul 14, 2021
Merged
1 task
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect icon Play after video ends and rewind
3 participants
@avelad @shaka-bot @theodab