Support Frequent Manifest Updates #3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
reviewed
Jun 23, 2021
| @@ -896,6 +897,8 @@ shaka.extern.ManifestConfiguration; | |||
| * If true, if the protocol is HTTP change it to HTTPs. | |||
| * @property {boolean} preferNativeHls | |||
| * If true, prefer native HLS playback when possible, regardless of platform. | |||
| * @property {number} updateIntervalSeconds | |||
| * The minimum number of seconds to see if the manifest has changes. | |||
There was a problem hiding this comment.
This is fine for now, but you're really making me wonder if we should have an event instead. The manifest parser could send an event (through the player, to keep streaming decoupled) any time it updates. It might be a little weird with the updateEvery() method we use for SegmentTemplate+duration, but once we have a mechanism for closing SegmentIndexes that we aren't using (thanks, @michellezhuogg!), that event would only fire once per media type (audio + video + maybe text).
joeyparrish
approved these changes
Jun 24, 2021
|
All tests passed! |
1 task
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3332