Fix #3384 Multiple Seek Backwards (e.g. Drag) #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streaming_engine maintains a reference to ongoing fetch operations for video, audio and text segments. Using these references, the fetch operations may be cancelled (e.g. due to a seek). Immediately following a seek, fetch operations were started for init segments and media segments. Upon completion of the init segment operation the reference to the media segment operation was overwritten with null, so could not be cancelled. This was particularly evident on platforms where the seek bar is dragged, as this produces multiple seeks. When dragging backwards it was possible for the buffer to contain segments beyond the play head. The solution is to await completion of the init segment fetch before starting the media segment fetch.
|
All tests passed! |
|
Thanks for your contributions! |
joeyparrish
pushed a commit
that referenced
this pull request
Jul 13, 2021
streaming_engine maintains a reference to ongoing fetch operations for video, audio and text segments. Using these references, the fetch operations may be cancelled (e.g. due to a seek). Immediately following a seek, fetch operations were started for init segments and media segments. Upon completion of the init segment operation the reference to the media segment operation was overwritten with null, so could not be cancelled. This was particularly evident on platforms where the seek bar is dragged, as this produces multiple seeks. When dragging backwards it was possible for the buffer to contain segments beyond the play head. The solution is to await completion of the init segment fetch before starting the media segment fetch. Fixed #3384
joeyparrish
pushed a commit
that referenced
this pull request
Jul 13, 2021
streaming_engine maintains a reference to ongoing fetch operations for video, audio and text segments. Using these references, the fetch operations may be cancelled (e.g. due to a seek). Immediately following a seek, fetch operations were started for init segments and media segments. Upon completion of the init segment operation the reference to the media segment operation was overwritten with null, so could not be cancelled. This was particularly evident on platforms where the seek bar is dragged, as this produces multiple seeks. When dragging backwards it was possible for the buffer to contain segments beyond the play head. The solution is to await completion of the init segment fetch before starting the media segment fetch. Fixed #3384 Backported to v3.0.x Change-Id: I2bd23ad1abc430e3f0cc413fb1aca863cb967356
1 task
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3384
streaming_engine maintains a reference to ongoing fetch operations for
video, audio and text segments. Using these references, the fetch
operations may be cancelled (e.g. due to a seek).
Immediately following a seek, fetch operations were started for init
segments and media segments. Upon completion of the init segment
operation the reference to the media segment operation was overwritten
with null, so could not be cancelled.
This was particularly evident on platforms where the seek bar is
dragged, as this produces multiple seeks. When dragging backwards it
was possible for the buffer to contain segments beyond the play head.
The solution is to await completion of the init segment fetch before
starting the media segment fetch.
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass