Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a method to get the ratio of video length buffered compared to bufferingGoal #3392

Merged
merged 11 commits into from
May 11, 2021
Merged

Adding a method to get the ratio of video length buffered compared to bufferingGoal #3392

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
26dc16c
Merge pull request #1 from google/master
surajkumar-sk May 5, 2021
68499bf
Merge pull request #2 from google/master
surajkumar-sk May 6, 2021
9a2fcf3
added method for checking video efficiency
surajkumar-sk May 7, 2021
f075f84
Update player.js
surajkumar-sk May 7, 2021
3d69e48
updated changes
surajkumar-sk May 8, 2021
073e0c9
updated player.js
surajkumar-sk May 8, 2021
83262a3
updated player.js
surajkumar-sk May 8, 2021
245a3b2
updated player.js
surajkumar-sk May 8, 2021
ad964c8
updated comment in player.js
surajkumar-sk May 11, 2021
ff4979f
updated variables
surajkumar-sk May 12, 2021
3172ce0
updated changes
surajkumar-sk May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ui/controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,29 @@ shaka.ui.Controls = class extends shaka.util.FakeEventTarget {
return this.seekBar_ ? this.seekBar_.getValue() : this.video_.currentTime;
}

/**
* Checking the efficiency of a video
surajkumar-sk marked this conversation as resolved.
Show resolved Hide resolved
* @return {?number}
surajkumar-sk marked this conversation as resolved.
Show resolved Hide resolved
* @export
*/
getBufferFillPercentage() {
surajkumar-sk marked this conversation as resolved.
Show resolved Hide resolved
const bufferedLength_ = this.video_.buffered.length;
surajkumar-sk marked this conversation as resolved.
Show resolved Hide resolved
const bufferedEnd_ =
bufferedLength_ ? this.video_.buffered.end(bufferedLength_ - 1) : 0;
const bufferingGoal_ = this.video_.currentTime +
Math.min(this.player_.getConfiguration().streaming.bufferingGoal,
surajkumar-sk marked this conversation as resolved.
Show resolved Hide resolved
(this.player_.seekRange().end - this.video_.currentTime));

if (bufferedEnd_ >= bufferingGoal_) {
return 100;
} else if (bufferedEnd_ < bufferingGoal_) {
return ((bufferedEnd_/bufferingGoal_)*100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This calculation is wrong, because it doesn't account for the starting point. The start of the range should be currentTime, not 0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeyparrish the formula of bufferingGoal_ does account for the starting point. I named the variable wrong, I'll try coming up with a better name. I am bad at it so I am open to suggestions.

Copy link
Contributor Author

@surajkumar-sk surajkumar-sk May 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the formula is wrong . The fraction should be between buffering goal and the length buffered after the current time . So the formula will be (bufferedEnd_-currentTime)/bufferingGoal

} else if (bufferedEnd_ <= this.video_.currentTime) {
surajkumar-sk marked this conversation as resolved.
Show resolved Hide resolved
return 0;
}
return 0;
}

/**
* @param {?number} time
* @export
Expand Down