Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of DASH and HLS demo content from MetaCDN #3350

Merged

Conversation

CaitlinOCallaghan
Copy link
Contributor

@CaitlinOCallaghan CaitlinOCallaghan commented Apr 19, 2021

Description

Addition of StreamShark (MetaCDN) HLS and DASH sample content for 180 degree and HD video.

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@google-cla
Copy link

google-cla bot commented Apr 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@CaitlinOCallaghan
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Apr 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@CaitlinOCallaghan
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Apr 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@shaka-bot
Copy link
Collaborator

All tests passed!

@CaitlinOCallaghan
Copy link
Contributor Author

@googlebot I signed it!

@TheModMaker
Copy link
Contributor

Your CLA is still invalid. Make sure the email you use to sign it exactly matches the email in your commits. Since you're using a company email, if you use a corporate CLA, you need to be on the allowed list of emails (and again, it must match exactly). I also don't see a corporate CLA for "streamshark", so it may not be valid yet.

@CaitlinOCallaghan
Copy link
Contributor Author

Thanks! Our CEO just signed the CLA form yesterday; another employee was the one who initially filled it out. I believe the CLA will be under either MetaCDN or StreamShark, as our company has two names.

@CaitlinOCallaghan
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Apr 29, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit ec9a38f into shaka-project:master Apr 29, 2021
@joeyparrish
Copy link
Member

Thanks!

@kevleyski
Copy link

Thanks again Joey and Caitlin!

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants